New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task: wiki page on updater scripts #283
Comments
Yeah, I wrote the script so it reads files from that subfolder because I wanted to avoid using files and folders that we know Firefox uses/used, to avoid potential conflicts. |
Caveats from 3.3...
I might be misunderstanding something, but I think that sounds potentially confusing/misleading. The script treats inactive preferences within multi-line comments differently depending on the mode of operation (append or merge). Are those the ones we're talking about? The default mode appends all lines indiscriminately, meaning that inactive preferences in I've been wondering for a while whether it would be worthwhile or not to make the script smarter interpreting and handling preferences, considering all the ways they can appear in user.js. What do you think? What would be an ideal criteria for you? |
To elaborate on my previous comment, a -hopefully- concise example: source user.js contains:
user-overrides.js contains:
Resulting user.js with append mode (default):
Resulting user.js with merge mode:
|
I figured I was probably missing something in my reasoning. Thanks for the clarification.
I considered that too some time ago, but didn't bother with it in the end. It's easy to implement though, just a couple of lines of code.
|
3.1:
I would rewrite that to:
IMO we can also remove the Script Example from that page.
3.2: 👍
|
mostly to keep a clean profile. If you reset all active+inactive prefs then basically everything is reset to FF's default, ie it could start to download all kinds of updates. For example if someone takes a while to look at the remaining user-set prefs in about:config, or the log in the console, or doesn't immediately restart FF for whatever other reason. |
... and system addons! well it's a bit weird/confusing that it says optional and then recommended. Maybe We should also add a recommendation in 3.2 to use parrot prefs in override files. |
IDK. it's totally unnecessary for [changes-only].js, [RFP-alternatives].js, [deprecated].js, [removed].js, and all future [changes-only].js files. And you also only need to run the other 2 files at most ONCE, so I don't think it makes sense to recommend to disable the network connection as a general rule. |
the files are named |
snip
The text was updated successfully, but these errors were encountered: