Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do something with intl.accept_languages #1759

Closed
Thorin-Oakenpants opened this issue Nov 2, 2023 · 2 comments
Closed

do something with intl.accept_languages #1759

Thorin-Oakenpants opened this issue Nov 2, 2023 · 2 comments

Comments

@Thorin-Oakenpants
Copy link
Contributor

Thorin-Oakenpants commented Nov 2, 2023

edit: https://bugzilla.mozilla.org/show_bug.cgi?id=1846224

in FF119+ the pref to make locale match en-US was deprecated, as long term RFP (and FPP might use it) want to be able to cover all languages etc - there's a lot of tightening to do, such as enforcing preferred languages to match specific defaults (i.e not changing the order or adding/removing any), maybe using a smaller subset of preferred languages - e.g es-ES as the only spanish one, and making the locale match the language (or a smaller subset of languages)

so this leaves us with changing users preferred language(s) but still leaking their locale. I think it only changes/leaks if your system locale matches the first part - e.g. my computer is en-CA (not really, it's an example), but I use en-US in the app, so it uses my system locale. If my system locale was de-DE it wouldn't change it - I'm not sure, it's not like I set up foreign language VMs

anyway, the fact remains that the pref is now somewhat useless, and when they cover all languages, then it becomes moot.

I do not want to make it inactive, because after prefCleaner is run, I do not know what Firefox will do. So we either remove it now, or leave it in for a while?

Anyone have any insight or thoughts?

@c3d1c06c-bf26-477e-b0eb-c50ef4477ba6

I do not want to make it inactive, because after prefCleaner is run, I do not know what Firefox will do.

Firefox sets it to the default language of the installer you used.

@Thorin-Oakenpants
Copy link
Contributor Author

will not add to scratchpad cleanup script for the same reasons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants