Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

118 diffs - 0704 is now default blank #1725

Closed
Thorin-Oakenpants opened this issue Sep 18, 2023 · 4 comments
Closed

118 diffs - 0704 is now default blank #1725

Thorin-Oakenpants opened this issue Sep 18, 2023 · 4 comments
Labels
enhancement

Comments

@Thorin-Oakenpants
Copy link
Contributor

Thorin-Oakenpants commented Sep 18, 2023 •
edited

https://bugzilla.mozilla.org/show_bug.cgi?id=1843763

-    prefValue.AssignLiteral(
-#ifdef MOZ_PROXY_BYPASS_PROTECTION
-        ""  // use none
-#else
-        "sftp:"  // use defaults (comma separated list)
-#endif
+    prefValue.AssignLiteral(""  // use none by default

Originally posted by @mik0l in #1050 (comment)
@mik0l
Copy link

mik0l commented Sep 18, 2023

"" // use none by default in 118

@Thorin-Oakenpants
Copy link
Contributor Author

ok. we haven't even got our 117-118 diffs yet (I would hope it would show up in those)

@mik0l
Copy link

mik0l commented Sep 18, 2023

It's a hidden pref

@Thorin-Oakenpants
Copy link
Contributor Author

i know it's hidden, says it right in the user.js :) earthlng's diffs do pick up (usually) on all these things

@Thorin-Oakenpants Thorin-Oakenpants changed the title 0704 disable GIO as a potential proxy bypass vector 118 diffs - 0704 is now default blank Sep 18, 2023
Thorin-Oakenpants added a commit that referenced this issue Oct 3, 2023
@Thorin-Oakenpants
update gio default, #1725
296d098
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Thorin-Oakenpants @mik0l