New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expand DoH #1694
Comments
note: We should add see #1688 (comment) for more @rusty-snake sorry for being lazy (and ignorant and I lack time) .. does that bug only relate to mode 0/2 ? |
Yes. |
thanks, that makes it easier to explain |
I also have |
Might it be a good idea to warn users on setting |
Yes, they got multiple times report from users about broken Doh where the cause was that the use set the bootstrap Pref sometime ago, then change the provider in the UI and broke DoH. On the other hand you should not report anything to mozilla if use AF and can reproduce it only by setting >100 prefs. |
user_pref("network.trr.mode", 3);
user_pref("network.dns.skipTRR-when-parental-control-enabled", false);
user_pref("network.trr.uri", "https://firefox.dns.nextdns.io/");
user_pref("network.trr.custom_uri", "https://firefox.dns.nextdns.io/");
// bootstrap DNS *must* be from the same provider as your DoH service, else DoH WILL break.
// https://bugzilla.mozilla.org/show_bug.cgi?id=1700378#c11
// ignore this pref, or set this at your own risk.
// user_pref("network.trr.bootstrapAddr", "45.90.28.0"); // NextDNS's plain DNS resolver I think something like this would be nice ^^ |
why do we need to add |
and can someone explain
/* 0712: set DoH provider
* [SETTING] Privacy & Security>DNS over HTTPS>Increased/Max>Choose provider ***/
// user_pref("network.trr.uri", "https://firefox.dns.nextdns.io/"); like does it need to be more like
do both need to be the same? |
Yes. Otherwise you mess up the UI on
|
ok, so custom presets the value in the text field if you select custom |
ooh, you replied .. I was doing some testing - you need to reload settings for the the custom change to get picked up, maybe even a new tab - seemed a bit iffy the first time |
So you don't have superpowers and can read and reply in 10 seconds 🦸 ? |
yeah, I get there are default uri, custom uri and uri - and the uri is the one set and used via the preferences UI, so it's fine to have different ones - personally, even though I trust my ISP you know not being in a shitty country like the USA .. I just use mode 3 with cloudflare |
i was in a different browser, it was only when I |
how's it looking now? @rusty-snake |
Good. |
hows this /* 5511: set DoH bootstrap address
* Firefox uses the system DNS to initially resolve the IP address of your DoH server. When set to
* a valid, working value that matches your "network.trr.uri" (0712) Firefox won't use the system
* DNS (ignoring local domains). If the IP doesn't match then DoH won't work ***/
// user_pref("network.trr.bootstrapAddr", "10.0.0.1") // [HIDDEN PREF] |
|
so you're saying to remove the |
I think it's fine to just remove it. If the users add an exceptions or tries to access localhost, local, etc-hosts defined, ... it is expected that FF bypasses DoH. |
done .. v117 ready for review .. see you tomorrow PS: thanks for your help .. have some 🍰 |
jesus fuck ... https://bugzilla.mozilla.org/show_bug.cgi?id=1586941 .. typical .. i wait 42 years before adding DoH stuff, and this happens |
Maybe this is a sign that 42 isn't the answer to life, the universe, and everything. |
i guess it's mostly harmless |
FWIW https://codeberg.org/rusty-snake/firefox-config/src/commit/fa47a46877db42af83bd91d52aa57301a793af4c/assets/user-overrides.js#L51-L56
Originally posted by @rusty-snake in #1688 (comment)
The text was updated successfully, but these errors were encountered: