New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cookie clearing exceptions don't work after Arkenfox 102 #1495
Comments
Worksforme (windows). I did have three instances where it did clear exceptions, but it seems stable now - it may be a case of not cleaning closing the app - I do use the quit button, but I did read a recent ticket about longer/munged shutdowns - IDK if that applies. Note: this non-clean shutdown sanitize issue is fixed in FF103 ^ IDK if that is what is causing your issue. What app are you using - snap? flat? etc? How are you closing Firefox? Otherwise, the only thing that sticks out is not clearing history, but that shouldn't affect it. I have not tested. Edit: PS: don't play with the |
next time it happens, check |
Same issue for me, not sure how to reproduce it. Maybe something to do with the "firefox is still running - quit cancel" message? Not sure It happened once yesterday and twice today, very irritating. I'm on Windows, Firefox Stable build 102.0 There is no All cookies are gone, exceptions were ignored |
@CptDinosaur This is still not ideal, because you're leaving data on disk you didn't expect to I suspect OP is the same |
Restarted with a clean shutdown and I still dont have I'll try forcing a non-graceful shutdown and see if that's the cause |
Yes, force quitting via task manager reproduces this. But it also happens randomly when I close then reopen, so this isn't ideal. While waiting for v103, is there anything I can do in the meantime so I don't keep losing all my cookies? |
Well, if it's not an ungraceful exit in some of these cases, then 103 won't fully solve it (unless it was something else that 103 fixes). In the meantime, you can't use the lifetimePolicy pref (it will just reset and migrate you), and you can't disable onShutdown and use Ctrl-Shift-Del manually when you go to bed, because that doesn't respect exceptions Has anyone filled a bugzilla on this. |
Maybe also set |
I was using FF 102 and lost my exceptions data twice because of power loss and once because of this intermittent wiping of data on graceful exits. PS: I thought "101" was meant to learn the basics, not to spoil the basics (in 102.) |
power losses, people shutting down their machine with firefox open etc. all fall under the "ungraceful exit" umbrella which is a known issue that will be fixed (it already is in Nightly for example). I think it would be useful if you people stick to FF102, create a new profile and apply the latest user.js to it; for example, knowing it only occurs in profiles where lifetime was set to 2 at some point would already be valuable IMO. of course feel free to say no if it sounds annoying.
|
Can't downgrade, it won't let you use the new profile since it's been upgraded to be incompatible |
I'll create a test profile with a separate FF 102 installation and try to reproduce this intermittent wiping of data on graceful exits.
When it occurred to me, I quit using Ctrl+Shift+Q
All of them.
Exactly |
I think for me it's been when I get the "Firefox is still running" error. All cookies are gone, checked via Cookie Quick Manager |
This seems promising. |
That's the downside. I had to uninstall everything, install FF 101, create a new profile with arkenfox 101, import my bookmarks, and install uBO again :/ |
open a bugzilla you guys, and report the console data
|
@CptDinosaur in the case of ungraceful exits it's a known issue that's fixed in 103+. if it's too annoying you could take a chance and install Beta or Nightly in the meantime I guess? not saying you absolutely should, but it works side by side with Stable, so maybe it's worth it for you. @aleyvo thanks, I'm trying the same on macOS, no luck so far. are you on windows? I'll stop the noise for now, if you guys open a bugzilla (you should since you had the issue at least once) please link it so I can hopefully add to it at some point. |
Yes, I'm on Windows. I'll try with a portable FF or with Sandbox. If I manage to reproduce it, I'll open a bugzilla and link it here for you guys. |
I don't know how to reproduce it either, I just tried and it did not log me out this time. It just does it randomly sometimes. Or maybe the times when it logged me out were actually me rebooting my computer with firefox open? I'll tell you when the issue happens next time. |
By the way, yes, ungracefully exiting firefox does log me out of all websites. So it is possible that the problem was with that in my case. However, people are reporting that they also have this even if they close firefox properly, so I'll keep this issue open for now. |
Been using FF 102 with AF 102 through the day. Tried closing it in multiple combined ways: using Ctrl+Shift+Q; using "X"; using the UI's "Exit"; while loading lots of tabs simultaneously; with multiple tabs opened in multiple windows; with PB window active; while FF was hanging/unresponsive; enabling/disabling the Session Restore recipe; triggering the migration code (lifetimePolicy) a couple times; letting the Browser Console open (orphan); letting the Library window open (orphan); while playing audio/videos; while downloading files; with Bookmarks shown/not shown... Nothing so far, didn't manage to reproduce the issue again. |
sounds like a race condition |
You can also flip both |
This may depend on the file system. I have all my cookies disappear on btrfs. I'm currently testing a hang on WebGL |
Also stopped clearing gmp-clearkey cookies, the dropbox site sets them. |
Ok, looks like in my case, the issue actually happens only when my laptop battery dies while Firefox is open, so it is related to 'ungraceful exit'. |
There's still something fucking wonky going on. I've lost mine 5 times, and it's not from improper shutdowns |
changelog for 102.0.1 says:
|
I lost my logins about 13 times today, Google gonna send swat team soon if this aint fixed. |
party van 馃帀
They backed out the migration code. This has no bearing on AF settings, as I would have been moving to resetting lifetimePolicy pref and using onShutdown anyway, as was planned to do so at least one release before migration. The cosmetic UI issue is immaterial. But, and I have not tested - this probably means you can override back to the old settings (i.e onShutdown cookies and offlineApps = false, lifetimePolicy = 2) and this should work to stop bulk sanitizing issues. What annoys me is that ESR102 users from here on in are a bit messed up. Would be nice if they backported the 103 fix for ungraceful onShutdown's to respect exceptions onStartup - at a minimum. |
pants, just so you know, |
well, it actually doesn't exist on any platform - it was deprecated in FF58 |
So what I'm seeing, just had my excepted storage wiped for the 8th time on a graceful exit .. is
IDK what that means exactly, but this shit is getting old |
I have faced this issue since the 102 update. It didn't occur in previous version. Is there a way to addin exception to override.js? |
The reason it didn't occur until 102 for AF users, is that we used the lifetimePolicy pref instead of clearing all cookies + offlineApps data on close. 102 then had a migration to reset lifetimePolicy etc, effectively making it useless, and we had to change. They have now backed that out in FF/ESR102.01 There are two issues going on here. One is the sanitize onStartup fallback (when sanitize onShutdown fails) doesn't respect exceptions, this is fixed in 103. This means when Firefox doesn't exit gracefully, e.g. exiting the app with the OS shutdown, or crashing, then everything gets wiped. The second issue is this is still happening for users who do (presumably) exit gracefully - i.e not crashing, and are exiting nicely with processes etc. Something is either failing to respect exceptions onShutdown, or it is triggering a sanitize on startup. In 103, we HAVE to move to using onShutdown (and ignoring lifetimePolicy) because that migration code is there in 103+, and all we would be doing is triggering the migration code every time we start the browser. I DO NOT KNOW if the issue will persist in 103 - it depends on the cause: some permission thing, some race condition, something else, IDFK. But for 102, and since this is also used for ESR users, I am putting out a dot release to revert the behavior. |
This is #1507 - basically changes are
|
AF 102-1 is out which importantly provides stability for ESR102 users Closing. If exceptions are not honored in 103+ (and we HAVE TO revert back to using onShutdown prefs in 103+), then we can open a new issue and take it from there |
馃煡 https://github.com/arkenfox/user.js/wiki/5.2-Troubleshooting
maywill be closed as invalid馃煪 REQUIRED INFO
You are still logged in
You are no longer logged in
My overrides
This worked as intended until the last version, but since v102 it no longer works.
The text was updated successfully, but these errors were encountered: