Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changelog: v102 #1491

Closed
Thorin-Oakenpants opened this issue Jul 2, 2022 · 11 comments
Closed

changelog: v102 #1491

Thorin-Oakenpants opened this issue Jul 2, 2022 · 11 comments
Labels
changelog

Comments

@Thorin-Oakenpants
Copy link
Contributor

Thorin-Oakenpants commented Jul 2, 2022 •
edited

  • date: 12-June-2022

FF102 release notes
FF102 for developers
FF102 security advisories

CHANGELOG

  • changed values in user.js v102 - see below
  • ⭐ both reverted back to false in v102-1
user_pref("privacy.clearOnShutdown.offlineApps", true);
user_pref("privacy.clearOnShutdown.cookies", true);
  • moved to 9999: DEPRECATED / REMOVED in user.js v102 - lifetimePolicy pref see below
  • ⭐ network.cookie.lifetimePolicy moved out of deprecated in v102-1 (active at 2)
user_pref("dom.storage.next_gen", true);
user_pref("network.cookie.lifetimePolicy", 2);
user_pref("security.ask_for_password", 2);
user_pref("security.password_lifetime", 5);

network.cookie.lifetimePolicy

⭐ migration code was backed out in FF102.1 FF102.0.1, so AF v102-1 has done the same, as it is causing too many issues, and we also need a stable 102 version for ESR users

Links

This pref is not technically deprecated until FF104, 1759665

Instead it is used to migrate users off of it: i.e they would reset it to 0 and enable custom history and enable sanitizing onShutdown for cookies, offlineApps (site data), and cache. This was not meant to happen until FF103, and they will most likely back out the "migration" code - see bugzilla 1777419, maybe in a FF102 point release if possible, but mainly for ESR102

Effectively this means, that until FF103, the UI for Privacy & Security > Cookies and Site Data> Delete cookies and site data when Firefox is closed is a bit munged, see #1489

However, none of that changes how we sanitize. We no longer use session-only cookies. You do not need it even with the code roll back. We use sanitize onShutdown, as exceptions are respected (and have been for a couple of releases).

Now we are moving to this, please note there is an issue fixed in FF103, where unexpected app exits/crashed/power-loss which then cause a sanitize onStartup, that routine will also respect exceptions

STATS

 STATS v102: up to and including section 4500, minus the parrots
 ==========
    total: 207
 inactive:  43
           ---
   active: 164
  default:  20 (at least)
      n/a:   2 (of the three prefs in 0204, only one will apply)
           ---
  flipped: 142 (at most)

 ESR DIFFS
 ======
v91
- 88.8 KB
- 1461 lines
- 1406 sloc
- end of section 4500: line 1080
- flipped: 167

v102
- 83.4 KB
- 1354 lines
- 1304 sloc
- end of section 4500: line 938
- flipped: 142

savings
-  6.1% - size: 5.4 KB
-  7.3% - lines: 107
-  7.3% - sloc: 102
- 13.1% - end of section 4500: 142 lines
- 15.0% - flipped: 25
@Thorin-Oakenpants
Copy link
Contributor Author

ALL HAIL PANTS

Collect the set

allhail

@Thorin-Oakenpants
Copy link
Contributor Author

Thorin-Oakenpants commented Jul 2, 2022 •
edited

since my last mention ...

We're closing in on the @bagder 's curl stats drinking habits, and he had a 200 year head start. We zipped past the 5k mark ( 🍻 were consumed) and are rapidly closing in on 6k (have ordered a keg)

currently at 19¼ Spartas + Gerard Butler

woo

@Thorin-Oakenpants Thorin-Oakenpants mentioned this issue Jul 3, 2022
Closed
@practik
Copy link

practik commented Jul 5, 2022

Thanks as always, especially for the lifetimePolicy fix this time around. Just starred the repo (never paid any attention to that stuff before) :-)

The heading /** SANITIZE MANUAL: ALL OR NOTHING ***/ could be clearer. How about /** SANITIZE MANUALLY: IGNORES COOKIE + SITE DATA EXCEPTIONS ***/?

@Thorin-Oakenpants
Copy link
Contributor Author

^ #1489 (comment) .. also I have to change it up anyway for the UI change

@Thorin-Oakenpants
Copy link
Contributor Author

honestly u gals .. five days and no love hailing for the ALL HAIL PANTS

@aleyvo
Copy link

aleyvo commented Jul 7, 2022

Apparently 102 hurt the feelings of everyone :(

@theltalpha
Copy link

honestly u gals .. five days and no love hailing for the ALL HAIL PANTS

Have to wait until Debian provides ESR102. ;) But thanks in advance. :)

@opusforlife2
Copy link

migration code was backed out in FF102.1

Was this meant to be 102.0.1? Because that's the version I am on, but I'm now being shown an update to 103. I'm still on AF 102. I was waiting for FF to update to a version 102.1 before applying the new AF. Should I be using the latest AF 102-1 instead?

@Thorin-Oakenpants
Copy link
Contributor Author

Thorin-Oakenpants commented Jul 26, 2022 •
edited

Was this meant to be 102.0.1

Yes, I have now fixed the typo above, thanks

AF 102-1 we flipped three prefs from AF 102 because FF backed the migration code out in FF102.0.1 - see https://github.com/arkenfox/user.js/releases/tag/102.1

Those three prefs are going to get flipped again in FF/AF v103 - so if you're on the OLD AF 102, then stay on that and update FF to 103 - that's what I'm on (pref wise, I actually use the PR version) - just updated to Ff103 myself about 10 minutes ago - it'll save you pissing around with sanitizing prefs getting flipped and re-flipped, and will stop the migration code from executing (on every startup in FF103+)

@opusforlife2
Copy link

And then later apply the 103 AF whenever it is released?

@Thorin-Oakenpants
Copy link
Contributor Author

^ yup

@Thorin-Oakenpants Thorin-Oakenpants mentioned this issue Aug 17, 2022
Closed
@Thorin-Oakenpants Thorin-Oakenpants mentioned this issue Nov 10, 2022
Closed
@Thorin-Oakenpants Thorin-Oakenpants mentioned this issue Jan 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
changelog
Milestone
No milestone
Development

No branches or pull requests
5 participants
@theltalpha @practik @Thorin-Oakenpants @opusforlife2 @aleyvo